linux-kernel - Re: [PATCH v4 2/2] ptrace, seccomp: add support for retrieving seccomp metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180221024925.2btdhf5oamn4tflz@cisco>
Date:   Tue, 20 Feb 2018 19:49:25 -0700
From:   Tycho Andersen <tycho@...ho.ws>
To:     Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Oleg Nesterov <oleg@...hat.com>, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] ptrace, seccomp: add support for retrieving
 seccomp metadata

On Tue, Feb 20, 2018 at 10:30:52PM +0300, Dmitry V. Levin wrote:
> > +struct seccomp_metadata {
> > +	unsigned long filter_off;	/* Input: which filter */
> > +	unsigned int flags;		/* Output: filter's flags */
> > +};
> 
> This "unsigned long" field is unacceptable unless you are willing
> to implement a compat layer for this arch-dependent type.
> 
> Please use an arch-independent type instead.
> See e.g. struct ptrace_peeksiginfo_args or struct struct seccomp_data.

Whoops, sorry about that. I believe I've addressed it in
https://lkml.org/lkml/2018/2/20/755

Cheers,

Tycho