linux-kernel - Re: [tip:x86/pti] objtool, retpolines: Integrate objtool with retpoline support more closely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180221125357.GJ25201@hirez.programming.kicks-ass.net>
Date:   Wed, 21 Feb 2018 13:53:57 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     David Woodhouse <dwmw2@...radead.org>
Cc:     hpa@...or.com, luto@...nel.org, arjan@...ux.intel.com,
        tglx@...utronix.de, dan.j.williams@...el.com,
        torvalds@...ux-foundation.org, gregkh@...uxfoundation.org,
        mingo@...nel.org, bp@...en8.de, linux-kernel@...r.kernel.org,
        dave.hansen@...ux.intel.com, jpoimboe@...hat.com,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/pti] objtool, retpolines: Integrate objtool with
 retpoline support more closely

On Wed, Feb 21, 2018 at 10:59:14AM +0000, David Woodhouse wrote:
> On Wed, 2018-02-21 at 02:34 -0800, tip-bot for Peter Zijlstra wrote:
> > 
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -489,6 +489,11 @@ KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
> >  KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
> >  endif
> >  
> > +ifneq ($(call cc-option,-mindirect-branch=thunk-extern -mindirect-branch-register),)
> > +  CC_HAS_RETPOLINE := 1
> > +endif
> > +export CC_HAS_RETPOLINE
> > +
> 
> That isn't the same as the check in arch/x86/Makefile.

That's because this crossed with the llvm cruft, right? I'll have a
look.