[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75Vc9GLy+GoVQb28K9mNREPFR3oD_uVaAWCQXSGmZ+EA+-w@mail.gmail.com>
Date: Wed, 21 Feb 2018 16:58:16 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Brian Belleville <bbellevi@....edu>
Cc: Jiri Kosina <jikos@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] floppy: Don't print kernel addresses to log in show_floppy
On Wed, Feb 21, 2018 at 12:54 AM, Brian Belleville <bbellevi@....edu> wrote:
> Outputting kernel addresses will reveal the locations of kernel code
> and data. Change the cases in show_floppy that print
> fd_timer.work.func and fd_timeout.work.func to use the %pf format
> specifier, which will print the symbol name, like what is done for the
> other function pointers printed by show_floppy. No longer output the
> value of cont. The variable cont is a pointer that can hold the
> address of kernel global variables.
Perhaps you missed %px introduction and hashing pointers otherwise.
OTOH I don't give a crap about floppy.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists