linux-kernel - RE: Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180222051418epcms1p515085d1b1fabaf50983ff2ecb3442c02@epcms1p5>
Date:   Thu, 22 Feb 2018 14:14:18 +0900
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message
 for a failed memory allocation in exynos_ppmu_probe()

> On 2018년 02월 14일 06:17, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Tue, 13 Feb 2018 22:10:42 +0100
> > 
> > Omit an extra message for a memory allocation failure in this function.
> > 
> > This issue was detected by using the Coccinelle software.
> > 
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > ---
> >  drivers/devfreq/event/exynos-ppmu.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> > index d96e3dc71cf8..72ac9113500d 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
> >  
> >  	size = sizeof(struct devfreq_event_dev *) * info->num_events;
> >  	info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
> > -	if (!info->edev) {
> > -		dev_err(&pdev->dev,
> > -			"failed to allocate memory devfreq-event devices\n");
> > +	if (!info->edev)
> >  		return -ENOMEM;
> > -	}
> > +
> >  	edev = info->edev;
> >  	platform_set_drvdata(pdev, info);
> >  
> > 
> 
> Acked-by: Chanwoo Choi <cw00.choi@...sung.com>
> 

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>