linux-kernel - Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b629082-c8cf-b53a-9ea3-b9da382f65c9@cogentembedded.com>
Date:   Thu, 22 Feb 2018 10:57:21 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     mst@...hat.com, christoffer.dall@...aro.org
Subject: Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

On 2/22/2018 9:24 AM, Jason Wang wrote:

> This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The
> reason is we try to batch packets for devmap which causes calling
> xdp_do_flush() under the process context. Simply disable premmption

    s/under/in/.
    Disabling preemption.

> may not work since process may move among processors which lead
> xdp_do_flush() to miss some flushes on some processors.
> 
> So simply revert the patch, a follow-up path will add the xdp flush
> correctly.
> 
> Reported-by: Christoffer Dall <christoffer.dall@...aro.org>
> Fixes: 762c330d670e ("tuntap: add missing xdp flush")
> Signed-off-by: Jason Wang <jasowang@...hat.com>
[...]

MBR, Sergei