| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Feb 2018 08:03:48 +0800
From: kbuild test robot <lkp@...el.com>
To: Oza Pawandeep <poza@...eaurora.org>
Cc: kbuild-all@...org, Bjorn Helgaas <bhelgaas@...gle.com>,
Philippe Ombredanne <pombredanne@...b.com>,
Thomas Gleixner <tglx@...utronix.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Kate Stewart <kstewart@...uxfoundation.org>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
Dongdong Liu <liudongdong3@...wei.com>,
Keith Busch <keith.busch@...el.com>, Wei Zhang <wzhang@...com>,
Sinan Kaya <okaya@...eaurora.org>,
Timur Tabi <timur@...eaurora.org>,
Oza Pawandeep <poza@...eaurora.org>
Subject: Re: [PATCH v8 5/7] PCI/AER: Unify aer error defines at single space
Hi Oza,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pci/next]
[also build test ERROR on v4.16-rc2 next-20180221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180222-060518
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-s2-02220611 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from include/trace/define_trace.h:96:0,
from include/ras/ras_event.h:414,
from drivers//ras/ras.c:15:
include/trace/../../include/ras/ras_event.h: In function 'trace_raw_output_aer_event':
>> include/trace/../../include/ras/ras_event.h:319:24: error: 'AER_CORRECTABLE' undeclared (first use in this function)
__entry->severity == AER_CORRECTABLE ? "Corrected" :
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(aer_event,
^~~~~~~~~~~
include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk'
TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
^~~~~~~~~
include/trace/../../include/ras/ras_event.h:319:24: note: each undeclared identifier is reported only once for each function it appears in
__entry->severity == AER_CORRECTABLE ? "Corrected" :
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(aer_event,
^~~~~~~~~~~
include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk'
TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
^~~~~~~~~
>> include/trace/../../include/ras/ras_event.h:320:25: error: 'AER_FATAL' undeclared (first use in this function)
__entry->severity == AER_FATAL ?
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
include/trace/../../include/ras/ras_event.h:298:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(aer_event,
^~~~~~~~~~~
include/trace/../../include/ras/ras_event.h:317:2: note: in expansion of macro 'TP_printk'
TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
^~~~~~~~~
vim +/AER_CORRECTABLE +319 include/trace/../../include/ras/ras_event.h
297b64c7 Tyler Baicar 2017-06-21 254
297b64c7 Tyler Baicar 2017-06-21 255 /*
0a2409aa Chen, Gong 2014-06-11 256 * PCIe AER Trace event
0a2409aa Chen, Gong 2014-06-11 257 *
0a2409aa Chen, Gong 2014-06-11 258 * These events are generated when hardware detects a corrected or
0a2409aa Chen, Gong 2014-06-11 259 * uncorrected event on a PCIe device. The event report has
0a2409aa Chen, Gong 2014-06-11 260 * the following structure:
0a2409aa Chen, Gong 2014-06-11 261 *
0a2409aa Chen, Gong 2014-06-11 262 * char * dev_name - The name of the slot where the device resides
0a2409aa Chen, Gong 2014-06-11 263 * ([domain:]bus:device.function).
0a2409aa Chen, Gong 2014-06-11 264 * u32 status - Either the correctable or uncorrectable register
0a2409aa Chen, Gong 2014-06-11 265 * indicating what error or errors have been seen
0a2409aa Chen, Gong 2014-06-11 266 * u8 severity - error severity 0:NONFATAL 1:FATAL 2:CORRECTED
0a2409aa Chen, Gong 2014-06-11 267 */
0a2409aa Chen, Gong 2014-06-11 268
0a2409aa Chen, Gong 2014-06-11 269 #define aer_correctable_errors \
99d44024 Chen, Gong 2014-08-13 270 {PCI_ERR_COR_RCVR, "Receiver Error"}, \
99d44024 Chen, Gong 2014-08-13 271 {PCI_ERR_COR_BAD_TLP, "Bad TLP"}, \
99d44024 Chen, Gong 2014-08-13 272 {PCI_ERR_COR_BAD_DLLP, "Bad DLLP"}, \
99d44024 Chen, Gong 2014-08-13 273 {PCI_ERR_COR_REP_ROLL, "RELAY_NUM Rollover"}, \
99d44024 Chen, Gong 2014-08-13 274 {PCI_ERR_COR_REP_TIMER, "Replay Timer Timeout"}, \
cb9a684a Chen, Gong 2014-08-13 275 {PCI_ERR_COR_ADV_NFAT, "Advisory Non-Fatal Error"}, \
cb9a684a Chen, Gong 2014-08-13 276 {PCI_ERR_COR_INTERNAL, "Corrected Internal Error"}, \
cb9a684a Chen, Gong 2014-08-13 277 {PCI_ERR_COR_LOG_OVER, "Header Log Overflow"}
0a2409aa Chen, Gong 2014-06-11 278
0a2409aa Chen, Gong 2014-06-11 279 #define aer_uncorrectable_errors \
846fc709 Chen, Gong 2014-08-13 280 {PCI_ERR_UNC_UND, "Undefined"}, \
cb9a684a Chen, Gong 2014-08-13 281 {PCI_ERR_UNC_DLP, "Data Link Protocol Error"}, \
cb9a684a Chen, Gong 2014-08-13 282 {PCI_ERR_UNC_SURPDN, "Surprise Down Error"}, \
99d44024 Chen, Gong 2014-08-13 283 {PCI_ERR_UNC_POISON_TLP,"Poisoned TLP"}, \
cb9a684a Chen, Gong 2014-08-13 284 {PCI_ERR_UNC_FCP, "Flow Control Protocol Error"}, \
99d44024 Chen, Gong 2014-08-13 285 {PCI_ERR_UNC_COMP_TIME, "Completion Timeout"}, \
99d44024 Chen, Gong 2014-08-13 286 {PCI_ERR_UNC_COMP_ABORT,"Completer Abort"}, \
99d44024 Chen, Gong 2014-08-13 287 {PCI_ERR_UNC_UNX_COMP, "Unexpected Completion"}, \
99d44024 Chen, Gong 2014-08-13 288 {PCI_ERR_UNC_RX_OVER, "Receiver Overflow"}, \
99d44024 Chen, Gong 2014-08-13 289 {PCI_ERR_UNC_MALF_TLP, "Malformed TLP"}, \
cb9a684a Chen, Gong 2014-08-13 290 {PCI_ERR_UNC_ECRC, "ECRC Error"}, \
cb9a684a Chen, Gong 2014-08-13 291 {PCI_ERR_UNC_UNSUP, "Unsupported Request Error"}, \
cb9a684a Chen, Gong 2014-08-13 292 {PCI_ERR_UNC_ACSV, "ACS Violation"}, \
cb9a684a Chen, Gong 2014-08-13 293 {PCI_ERR_UNC_INTN, "Uncorrectable Internal Error"},\
cb9a684a Chen, Gong 2014-08-13 294 {PCI_ERR_UNC_MCBTLP, "MC Blocked TLP"}, \
cb9a684a Chen, Gong 2014-08-13 295 {PCI_ERR_UNC_ATOMEG, "AtomicOp Egress Blocked"}, \
cb9a684a Chen, Gong 2014-08-13 296 {PCI_ERR_UNC_TLPPRE, "TLP Prefix Blocked Error"}
0a2409aa Chen, Gong 2014-06-11 297
0a2409aa Chen, Gong 2014-06-11 @298 TRACE_EVENT(aer_event,
0a2409aa Chen, Gong 2014-06-11 299 TP_PROTO(const char *dev_name,
0a2409aa Chen, Gong 2014-06-11 300 const u32 status,
0a2409aa Chen, Gong 2014-06-11 301 const u8 severity),
0a2409aa Chen, Gong 2014-06-11 302
0a2409aa Chen, Gong 2014-06-11 303 TP_ARGS(dev_name, status, severity),
0a2409aa Chen, Gong 2014-06-11 304
0a2409aa Chen, Gong 2014-06-11 305 TP_STRUCT__entry(
0a2409aa Chen, Gong 2014-06-11 306 __string( dev_name, dev_name )
0a2409aa Chen, Gong 2014-06-11 307 __field( u32, status )
0a2409aa Chen, Gong 2014-06-11 308 __field( u8, severity )
0a2409aa Chen, Gong 2014-06-11 309 ),
0a2409aa Chen, Gong 2014-06-11 310
0a2409aa Chen, Gong 2014-06-11 311 TP_fast_assign(
0a2409aa Chen, Gong 2014-06-11 312 __assign_str(dev_name, dev_name);
0a2409aa Chen, Gong 2014-06-11 313 __entry->status = status;
0a2409aa Chen, Gong 2014-06-11 314 __entry->severity = severity;
0a2409aa Chen, Gong 2014-06-11 315 ),
0a2409aa Chen, Gong 2014-06-11 316
0a2409aa Chen, Gong 2014-06-11 317 TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
0a2409aa Chen, Gong 2014-06-11 318 __get_str(dev_name),
0a2409aa Chen, Gong 2014-06-11 @319 __entry->severity == AER_CORRECTABLE ? "Corrected" :
0a2409aa Chen, Gong 2014-06-11 @320 __entry->severity == AER_FATAL ?
0a2409aa Chen, Gong 2014-06-11 321 "Fatal" : "Uncorrected, non-fatal",
0a2409aa Chen, Gong 2014-06-11 322 __entry->severity == AER_CORRECTABLE ?
0a2409aa Chen, Gong 2014-06-11 323 __print_flags(__entry->status, "|", aer_correctable_errors) :
0a2409aa Chen, Gong 2014-06-11 324 __print_flags(__entry->status, "|", aer_uncorrectable_errors))
0a2409aa Chen, Gong 2014-06-11 325 );
0a2409aa Chen, Gong 2014-06-11 326
:::::: The code at line 319 was first introduced by commit
:::::: 0a2409aad38e97b1db55e6515b990be7b17060f6 trace, AER: Move trace into unified interface
:::::: TO: Chen, Gong <gong.chen@...ux.intel.com>
:::::: CC: Tony Luck <tony.luck@...el.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (27224 bytes)
Powered by blists - more mailing lists