linux-kernel - Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2093598.TLbMltDcSo@blindfold>
Date:   Thu, 22 Feb 2018 15:30:09 +0100
From:   Richard Weinberger <richard@....at>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     boris.brezillon@...e-electrons.com, dwmw2@...radead.org,
        computersforpeace@...il.com, marek.vasut@...il.com,
        cyrille.pitchen@...ev4u.fr, maximlevitsky@...il.com,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ezequiel@...guardiasur.com.ar, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro

Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:
> @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct mtd_info
> *mtd) break;
>  	}
>  	doc->chips_per_floor = i;
> -	printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
> +	pr_debug("Detected %d chips per floor.\n", i);

<bike-shedding>

You are aware of the fact that printk(KERN_DEBUG and pr_debug() are not 
equivalent?
Not a big deal, just want to make sure that you understand what you are doing. 
:-)

</bike-shedding>

Thanks,
//richard