linux-kernel - Re: [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda3Tc0U_UJAyu-Jhja3E8xg2FRcswcxe2hMofrrXLTAEQ@mail.gmail.com>
Date:   Thu, 22 Feb 2018 15:46:55 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD

On Wed, Feb 14, 2018 at 4:55 PM, Charles Keepax
<ckeepax@...nsource.cirrus.com> wrote:

> Now GPIOD has support for both pdata systems and for non-standard DT
> bindings the Arizona reset GPIO can be converted to use it.
>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
(...)
> +       pdata->reset = devm_gpiod_get_from_of_node(arizona->dev,
> +                                                  arizona->dev->of_node,
> +                                                  "wlf,reset", 0,
> +                                                  GPIOD_OUT_LOW,
> +                                                  "arizona /RESET");

It seems this call is really useful.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Also thanks for testing this API, I had nothing to test it on...

Yours,
Linus Walleij