linux-kernel - [PATCH 1/1] EDAC, sb_edac: Fix out of bound write during DIMM configuration on KNL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1519312693-4789-1-git-send-email-anna.karbownik@intel.com>
Date:   Thu, 22 Feb 2018 16:18:13 +0100
From:   Anna Karbownik <anna.karbownik@...el.com>
To:     mchehab@...nel.org, bp@...en8.de, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     dan.carpenter@...cle.com, tony.luck@...el.com,
        jim.m.snow@...el.com, qiuxu.zhuo@...el.com,
        lukasz.odzioba@...el.com, krzysztof.paliswiat@...el.com,
        anna.karbownik@...el.com
Subject: [PATCH 1/1] EDAC, sb_edac: Fix out of bound write during DIMM configuration on KNL

From: akarbown <anna.karbownik@...el.com>

In one of the previous patches we decreased NUM_CHANNELS from 8 to 4, but
it is not enough for Knights Landing which supports up to 6 channels.

This caused unattended writes to pvt->mirror_mode and pvt->tolm variables
which don't pay critical role on KNL code path, so driver was somehow functional.

The easiest way of fixing it is to change NUM_CHANNELS to 6.
An alternative solution would be to restructure KNL part of the driver to
2MC/3channel representation.

Fixes: 3286d3eb906c ("EDAC, sb_edac: Drop NUM_CHANNELS from 8 back to 4")
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: Anna Karbownik <anna.karbownik@...el.com>
---
 drivers/edac/sb_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index f34430f..8721002 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -279,7 +279,7 @@ static inline int sad_pkg(const struct interleave_pkg *table, u32 reg,
  * sbridge structs
  */

-#define NUM_CHANNELS		4	/* Max channels per MC */
+#define NUM_CHANNELS		6	/* Max channels per MC */
 #define MAX_DIMMS		3	/* Max DIMMS per channel */
 #define KNL_MAX_CHAS		38	/* KNL max num. of Cache Home Agents */
 #define KNL_MAX_CHANNELS	6	/* KNL max num. of PCI channels */
-- 
1.8.3.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.