linux-kernel - Re: [PATCH NAND v4] mtd: nand: Replace printk() with appropriate pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180222164432.0f2b1e56@bbrezillon>
Date:   Thu, 22 Feb 2018 16:44:32 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     boris.brezillon@...e-electrons.com, richard@....at,
        dwmw2@...radead.org, computersforpeace@...il.com,
        marek.vasut@...il.com, cyrille.pitchen@...ev4u.fr,
        maximlevitsky@...il.com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ezequiel@...guardiasur.com.ar,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH NAND v4] mtd: nand: Replace printk() with appropriate
 pr_*() macro

On Thu, 22 Feb 2018 20:59:27 +0530
Shreeya Patel <shreeya.patel23498@...il.com> wrote:

> The log levels embedded with the name are more concise than
> printk.

If you don't mind, I'll replace the above sentence by:

"
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
"

The patch looks good otherwise, so I should apply it soon.

If you're okay, and Julia and Ezequiel are okay too, I'd like to move
to the next step and have you work on an ->exec_op() conversion
(jz4780?).

Of course, that does not prevent you from continuing the
printk()/dev_xx() conversion.

-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com