linux-kernel - Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180222155411.gnn42poawtlf3rze@verge.net.au>
Date:   Thu, 22 Feb 2018 16:54:14 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     jacopo mondi <jacopo@...ndi.org>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>, geert@...ux-m68k.org,
        magnus.damm@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 09:23 PM, Simon Horman wrote:
> 
> > ...
> > 
> >>>>>>>> +			clocks = <&cpg CPG_MOD 812>;
> >>>>>>>> +			power-domains = <&sysc 32>;
> >>>>>>>> +			resets = <&cpg 812>;
> >>>>>>>> +			phy-mode = "rgmii-txid";
> >>>>>>>
> >>>>>>>    Why not just "rgmii"? TX delay is a board specific detail, no?
> >>>>>>>
> >>>>>> I admit I took this one straight from r8a7796 dtsi.
> >>>>>> Would you like to me resend and change this?
> >>>>>
> >>>>>    Yes, unless Simon would fix it while merging...
> >>>>
> >>>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >>>
> >>>    Yes.
> >>
> >>    Apparently that means that this prop should be overridden in the board file
> >> (which may not be an easy task given the board is Salvator-XS again).
> >>
> >> [...]
> > 
> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
> 
>    In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.
> 
> > I feel that I'm missing an important point here.
> 
>    Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>    unjustified in my current understanding). Thus such board override
>    wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>    in htis series, so I'm now thinking a respin of this series is needed
>    anyway... sorry for being unclear. :-)

While I've applied other patches in this series I have
not applied this one - mainly to allow this discussion to conclude.

Is an appropriate solution to do the following?

1) Atomically update
   a) r8a779{5|6}.dtsi to use "rgmii" and
   b) salvator-common.dtsi to use "rgmii-txid"
2) Update this patch to use "rgmii"

Sorry if I'm still missing the point.