linux-kernel - [PATCH] drm/p[111: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Feb 2018 17:24:12 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Eric Anholt <eric@...olt.net>
Cc:     Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>,
        Linus Walleij <linus.walleij@...aro.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Tom Cooksey <tom.cooksey@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH] drm/p[111: add CONFIG_OF dependency

We cannot select a symbol without meeting its other dependencies:

warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF)
drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':
drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node'
  vga->bridge.of_node = pdev->dev.of_node;
             ^

Here it seems reasonable to depend on CONFIG_OF, as all platforms
using this driver already require that anyway.

Fixes: 49f81d80ab84 ("drm/pl111: Support handling bridge timings")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/gpu/drm/pl111/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
index 82cb3e60ddc8..776448e8d4ee 100644
--- a/drivers/gpu/drm/pl111/Kconfig
+++ b/drivers/gpu/drm/pl111/Kconfig
@@ -3,6 +3,7 @@ config DRM_PL111
 	depends on DRM
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on COMMON_CLK
+	depends on OF
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
-- 
2.9.0