linux-kernel - RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cd107dfe3ec4dda89457b112e8f79e5@AcuMS.aculab.com>
Date:   Thu, 22 Feb 2018 18:42:32 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Christoph Hellwig' <hch@...radead.org>,
        Oza Pawandeep <poza@...eaurora.org>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dongdong Liu <liudongdong3@...wei.com>,
        "Keith Busch" <keith.busch@...el.com>, Wei Zhang <wzhang@...com>,
        Sinan Kaya <okaya@...eaurora.org>,
        Timur Tabi <timur@...eaurora.org>
Subject: RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

From: Christoph Hellwig
> > -	pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
> > -	/* TODO: Should kernel panic here? */
> > -	pci_info(dev, "AER: Device recovery failed\n");
> > -}
> > +EXPORT_SYMBOL(pci_find_aer_service);
> 
> EXPORT_SYMBPOL_GPL please.

Is this a function that a 'normal' PCIe device driver would need to call?
If so it is a PITA requiring all drivers that want AER to be GPL.

	David