linux-kernel - Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Feb 2018 12:21:40 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Jeremy Cline <jeremy@...ine.org>
Cc:     Mario Limonciello <mario.limonciello@...l.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Alex Hung <alex.hung@...onical.com>
Subject: Re: [PATCH] platform/x86: Only activate tablet mode switch on
 2-in-1's

On Thu, Feb 22, 2018 at 08:15:51PM +0000, Jeremy Cline wrote:
> On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote:
> > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6
> > interface but don't initialize the bit that intel-vbtn uses to
> > represent switching tablet mode.
> > 
> > By running this only on real 2-in-1's it shouldn't cause false
> > positives.
> > 
> > Fixes: 30323fb6d5 ("Support tablet mode switch")
> > Reported-by: Jeremy Cline <jeremy@...ine.org>
> > Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>
> > ---
> > Note: I also moved the code for detecting tablet into it's own
> > function.  To keep things under 80 lines with if statements was
> > making the code very unreadable otherwise.
> > 
...
> 
> Tested-by: Jeremy Cline <jeremy@...ine.org>

Wow, incredible turn around time Mario and Jeremy. Doing some
confirmation on my end, and will queue up to Fixes for 4.16 RC cycle.

-- 
Darren Hart
VMware Open Source Technology Center