linux-kernel - Re: [PATCH] PCMCIA / PM: Avoid noirq suspend aborts during suspend-to-idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gCfaGdniLqVLRfS0riVgAYg6-5waj4=HeNFRWk8G9nAQ@mail.gmail.com>
Date:   Thu, 22 Feb 2018 22:49:36 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCMCIA / PM: Avoid noirq suspend aborts during suspend-to-idle

On Thu, Feb 22, 2018 at 6:32 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Thu, Feb 22, 2018 at 5:45 PM, Dominik Brodowski
> <linux@...inikbrodowski.net> wrote:
>> On Wed, Feb 21, 2018 at 01:24:16PM +0100, Rafael J. Wysocki wrote:
>>> Avoid that by using a new socket state flag, SOCKET_IN_RESUME,
>>> to indicate that socket_early_resume() has already run for the
>>> socket in which case socket_suspend() will do minimum handling
>>> and return 0.
>>
>> That looks to be *too* minimal: For example, yenta_socket does some
>> socket set-up in ->init(), which is called by socket_early_resume().
>> That needs to be undone by ->suspend().
>
> I see.
>
>> What about this variant (untested, not even compile-tested)?
>
> It looks fine to me, I'll test it later today.

I had to make it compile (by fixing a typo), but it works for me after
that, so I'll queue it up.

Thanks,
Rafael