linux-kernel - Re: [PATCH v2 1/3] HID: add driver for Valve Steam Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Feb 2018 23:54:26 +0100
From:   Rodrigo Rivas Costa <rodrigorivascosta@...il.com>
To:     Cameron Gutman <aicommander@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 1/3] HID: add driver for Valve Steam Controller

On Tue, Feb 20, 2018 at 09:32:08PM -0800, Cameron Gutman wrote:
> On 02/20/2018 11:33 AM, Rodrigo Rivas Costa wrote:
> > +static void steam_work_connect_cb(struct work_struct *work)
> > +{
> > +	struct steam_device *steam = container_of(work, struct steam_device,
> > +							work_connect);
> > +	unsigned long flags;
> > +	bool connected;
> > +	int ret;
> > +
> > +	spin_lock_irqsave(&steam->lock, flags);
> > +	connected = steam->connected;
> > +	spin_unlock_irqrestore(&steam->lock, flags);
> > +
> > +	if (connected) {
> > +		if (steam->input) {
> > +			dbg_hid("%s: already connected\n", __func__);
> > +			return;
> > +		}
> > +		ret = steam_register(steam);
> > +		if (ret) {
> > +			hid_err(steam->hdev,
> > +				"%s:steam_register failed with error %d\n",
> > +				__func__, ret);
> > +			return;
> > +		}
> > +	} else {
> > +		steam_unregister(steam);
> 
> I think you need synchronization here. You don't want to be in the middle of
> processing a HID event or power supply update and have your device freed out
> from underneath you.
> 
> xpad uses RCU to avoid this race.

Ah, I see, if we get an input message just after the "disconnect"
packet, (unlikely) it could file. I'll don't know RCU very will but I'll
try and do my best.

Please, stay tuned for v3.
Thanks.
Rodrigo