linux-kernel - Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180223002142.GG14632@bhelgaas-glaptop.roam.corp.google.com>
Date:   Thu, 22 Feb 2018 18:21:42 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Tomasz Figa <tfiga@...omium.org>,
        Paul Burton <paul.burton@...s.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vineet Gupta <vgupta@...opsys.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Christoph Hellwig <hch@....de>,
        Michal Nazarewicz <mina86@...a86.com>,
        Rob Herring <robh@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Paul Mackerras <paulus@...abs.org>,
        Will Deacon <will.deacon@....com>,
        Tony Lindgren <tony@...mide.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@...nel.org> wrote:
> > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> >> 'default N' should be 'default n', though they happen to have the same
> >> effect here, due to undefined symbols (N in this case) evaluating to n
> >> in a tristate sense.
> >>
> >> Remove the default instead of changing it. bool and tristate symbols
> >> implicitly default to n.
> >
> > s/bool/Bool/
> 
> Not a great excuse, but I was thinking syntactically -- 'bool' and
> 'tristate' symbols... :)
> 
> >
> >> Discovered with the
> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> >> script.
> >>
> >> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> >
> > Since only this patch was posted to linux-pci, I assume it will be merged
> > via some other tree.
> 
> I didn't have a particular tree in mind for this patchset. I imagined
> people would pick up patches into the trees where they make the most
> sense, and only created the patchset to keep track of the patches more
> easily. Might have created some confusion in retrospect.
> 
> I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> individual patches by the way.

OK, then either Lorenzo or I will pick it up.

It's in drivers/pci/host/, so ideally Lorenzo will take it since he
looks after everything else in there.

Bjorn