linux-kernel - Re: [PATCH 1/9] scsi: ufs: Allowing power mode change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13563e4e-1b4d-8791-12ec-8fcb752f3b96@codeaurora.org>
Date:   Fri, 23 Feb 2018 12:33:46 +0530
From:   "Asutosh Das (asd)" <asutoshd@...eaurora.org>
To:     Kyuho Choi <chlrbgh0@...il.com>
Cc:     subhashj@...eaurora.org, cang@...eaurora.org,
        vivek.gautam@...eaurora.org, rnayak@...eaurora.org,
        vinholikatti@...il.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        Yaniv Gardi <ygardi@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] scsi: ufs: Allowing power mode change

On 2/23/2018 10:40 AM, Kyuho Choi wrote:
> Hi Asutosh,
> 
> I've simple question in below.
> 
> On 2/21/18, Asutosh Das <asutoshd@...eaurora.org> wrote:
>> From: Yaniv Gardi <ygardi@...eaurora.org>
>>
>> Due to M-PHY issues, moving from HS to any other mode or gear or
>> even Hibern8 causes some un-predicted behavior of the device.
>> This patch fixes this issues.
>>
>> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>
>> Signed-off-by: Subhash Jadavani <subhashj@...eaurora.org>
>> Signed-off-by: Can Guo <cang@...eaurora.org>
>> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
>> ---
>>   drivers/scsi/ufs/ufshcd.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 011c336..d74d529 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -4167,9 +4167,13 @@ static int ufshcd_link_startup(struct ufs_hba *hba)
>>   			goto out;
>>   	} while (ret && retries--);
>>
>> -	if (ret)
>> +	if (ret) {
>>   		/* failed to get the link up... retire */
>>   		goto out;
>> +	} else {
>> +		ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 0);
>> +		ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 1);
>> +	}
>>
> 
> Every ufs host has same issue and affected?.
> 
>>   	if (link_startup_again) {
>>   		link_startup_again = false;
>> --
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
>> Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
>> Foundation Collaborative Project.
>>
>>
Hi Choi
Thanks for the review.

No - I can't say if every host has the same issue. However, I get your 
point. It could be done with a quirk.

I'll fix this in v2 after collating all the comments from the rest of 
the patches.

-asd

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project