linux-kernel - Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5A8F608E.4030509@samsung.com>
Date:   Fri, 23 Feb 2018 09:30:06 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Marian Mihailescu <mihailescu2m@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on
 Exynos4210

On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote:
> Typo in unit address of PPMU ACP caused DTC warnings:
> 
>     arch/arm/boot/dts/exynos4412-odroidu3.dtb:
>         Warning (simple_bus_reg): Node /soc/ppmu_acp@...e0000 simple-bus unit address format error, expected "106e0000"
> 
> PPMU ACP (under 0x10ae0000 address) is present only in Exynos4210 so
> move this node to exynos4210.dtsi with fixing the reg address to proper
> one.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  arch/arm/boot/dts/exynos4.dtsi    | 6 ------
>  arch/arm/boot/dts/exynos4210.dtsi | 6 ++++++
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 967cd02401c5..909a9f2bf5be 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -821,12 +821,6 @@
>  			status = "disabled";
>  		};
>  
> -		ppmu_acp: ppmu_acp@...e0000 {
> -			compatible = "samsung,exynos-ppmu";
> -			reg = <0x106e0000 0x2000>;
> -			status = "disabled";
> -		};
> -
>  		ppmu_rightbus: ppmu_rightbus@...a0000 {
>  			compatible = "samsung,exynos-ppmu";
>  			reg = <0x112a0000 0x2000>;
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> index 853604d91158..88fb47cef9a8 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -162,6 +162,12 @@
>  			iommus = <&sysmmu_g2d>;
>  		};
>  
> +		ppmu_acp: ppmu_acp@...e0000 {
> +			compatible = "samsung,exynos-ppmu";
> +			reg = <0x10ae0000 0x2000>;
> +			status = "disabled";
> +		};
> +
>  		ppmu_lcd1: ppmu_lcd1@...40000 {
>  			compatible = "samsung,exynos-ppmu";
>  			reg = <0x12240000 0x2000>;
> 

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics