linux-kernel - Re: [PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180223081725.GB12617@kroah.com>
Date:   Fri, 23 Feb 2018 09:17:25 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Debopriyo Ghosh <debopriyosoftdev@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__
 instead of function name and proper code ident for else statement

On Fri, Feb 23, 2018 at 12:57:16AM +0530, Debopriyo Ghosh wrote:
> From: Debopriyo <debopriyosoftdev@...il.com>
> 
> This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found
> by the checkpatch.pl tool
> 1.Use of __func__ instead of function name
> 2.proper code identation for else statement

When you have to list different things you are doing in a single patch,
that's a huge sign you need to break the patch up into multiple ones.

Please do that here.

thanks,

greg k-h