linux-kernel - Re: [2/2] crypto: bcm: One function call less in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46bd73e1-73ae-24b2-49d6-623328c14e76@users.sourceforge.net>
Date:   Fri, 23 Feb 2018 09:23:00 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        linux-crypto@...r.kernel.org
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Rice <rob.rice@...adcom.com>,
        Steve Lin <steven.lin1@...adcom.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [2/2] crypto: bcm: One function call less in do_shash() after
 error detection

> This patch is pointless as kfree on NULL is a no-op.

I prefer to avoid unnecessary function calls generally.

Regards,
Markus