linux-kernel - Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180223115242.GA21946@e107981-ln.cambridge.arm.com>
Date:   Fri, 23 Feb 2018 11:52:50 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     helgaas@...nel.org, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, tfiga@...omium.org,
        paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, linus.walleij@...aro.org,
        vgupta@...opsys.com, mgorman@...hsingularity.net, hch@....de,
        mina86@...a86.com, robh@...nel.org, sboyd@...eaurora.org,
        paulus@...abs.org, will.deacon@....com, tony@...mide.com,
        npiggin@...il.com, yamada.masahiro@...ionext.com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
> 
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
> 
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.

I have remove this link - it can become stale so I do not think it is
worth adding it to the log.

I have also reworded the $SUBJECT.

Applied to pci/host/misc for v4.17, let me know if that's fine for you.

Thanks,
Lorenzo

> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
> 
>  drivers/pci/host/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
>  config VMD
>  	depends on PCI_MSI && X86_64 && SRCU
>  	tristate "Intel Volume Management Device Driver"
> -	default N
>  	---help---
>  	  Adds support for the Intel Volume Management Device (VMD). VMD is a
>  	  secondary PCI host bridge that allows PCI Express root ports,
> -- 
> 2.14.1
>