linux-kernel - Re: [PATCH] auxdisplay: panel: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nrH=x3T6Nzg76p1b1p5K9iPYQWZGFKMOSaKvBdRzU8zA@mail.gmail.com>
Date:   Fri, 23 Feb 2018 14:19:50 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] auxdisplay: panel: mark expected switch fall-throughs

Hi Gustavo,

On Thu, Oct 12, 2017 at 11:35 PM, Gustavo A. R. Silva
<garsilva@...eddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> In this particular case, notice that I replaced the "no break here,
> fall through" comments with "fall through" comments, which is what
> GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/auxdisplay/panel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
> index 6911acd..8b80a97 100644
> --- a/drivers/auxdisplay/panel.c
> +++ b/drivers/auxdisplay/panel.c
> @@ -1372,7 +1372,7 @@ static void panel_process_inputs(void)
>                                 break;
>                         input->rise_timer = 0;
>                         input->state = INPUT_ST_RISING;
> -                       /* no break here, fall through */
> +                       /* fall through */
>                 case INPUT_ST_RISING:
>                         if ((phys_curr & input->mask) != input->value) {
>                                 input->state = INPUT_ST_LOW;
> @@ -1385,11 +1385,11 @@ static void panel_process_inputs(void)
>                         }
>                         input->high_timer = 0;
>                         input->state = INPUT_ST_HIGH;
> -                       /* no break here, fall through */
> +                       /* fall through */
>                 case INPUT_ST_HIGH:
>                         if (input_state_high(input))
>                                 break;
> -                       /* no break here, fall through */
> +                       /* fall through */

Thanks! I will put it in my queue (I sent a similar one a few days
ago, so I will pick yours).

Cheers,
Miguel

>                 case INPUT_ST_FALLING:
>                         input_state_falling(input);
>                 }
> --
> 2.7.4
>