linux-kernel - Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180223152553.GA20248@sophia>
Date:   Fri, 23 Feb 2018 10:25:53 -0500
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>, linux-gpio@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"

On Fri, Feb 23, 2018 at 04:19:01PM +0100, Arnd Bergmann wrote:
>On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
><mail@...iej.szmigiero.name> wrote:
>> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>>
>> Now that the patch series changing ISA_BUS_API dependency to selection
>> was merged this reversion will do the same for gpio-winbond driver to
>> make it consistent with other ISA bus gpio drivers.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
>
>I still see a number of other users of 'depends on ISA_BUS_API' in linux-next:
>
>drivers/gpio/Kconfig:   depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig:   depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig:   depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig:   depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig:   depends on ISA_BUS_API
>drivers/gpio/Kconfig:   depends on ISA_BUS_API
>drivers/iio/adc/Kconfig:        depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/counter/Kconfig:    depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/dac/Kconfig:        depends on X86 && ISA_BUS_API
>drivers/watchdog/Kconfig:       depends on X86 && ISA_BUS_API
>
>Did you change all of the above? I would really like to avoid mixing
>'select' and 'depends on' here, as that will likely cause other circular
>dependencies in the future.
>
>       Arnd

Those 'depends on' for ISA_BUS_API are resolved in the devel branch of
the linux-gpio tree; this revert patch should be applied there before
being picked up later for linux-next.

William Breathitt Gray