linux-kernel - Re: [PATCH] kvm: fix warning for non-x86 builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7825efa7-da58-ad95-1d41-71eefb9784c3@redhat.com>
Date:   Fri, 23 Feb 2018 19:06:52 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sebastian Ott <sebott@...ux.vnet.ibm.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: fix warning for non-x86 builds

On 22/02/2018 13:04, Sebastian Ott wrote:
> Fix the following sparse warning by moving the prototype
> of kvm_arch_mmu_notifier_invalidate_range() to linux/kvm_host.h .
> 
>   CHECK   arch/s390/kvm/../../../virt/kvm/kvm_main.c
> arch/s390/kvm/../../../virt/kvm/kvm_main.c:138:13: warning: symbol 'kvm_arch_mmu_notifier_invalidate_range' was not declared. Should it be static?
> 
> Signed-off-by: Sebastian Ott <sebott@...ux.vnet.ibm.com>
> ---
>  arch/x86/include/asm/kvm_host.h | 3 ---
>  include/linux/kvm_host.h        | 3 +++
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index dd6f57a54a26..0a9e330b34f0 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1464,7 +1464,4 @@ static inline int kvm_cpu_get_apicid(int mps_cpu)
>  #define put_smstate(type, buf, offset, val)                      \
>  	*(type *)((buf) + (offset) - 0x7e00) = val
>  
> -void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
> -		unsigned long start, unsigned long end);
> -
>  #endif /* _ASM_X86_KVM_HOST_H */
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index ac0062b74aed..ed3d4ddbaff3 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -1272,4 +1272,7 @@ static inline long kvm_arch_vcpu_async_ioctl(struct file *filp,
>  }
>  #endif /* CONFIG_HAVE_KVM_VCPU_ASYNC_IOCTL */
>  
> +void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
> +		unsigned long start, unsigned long end);
> +
>  #endif
> 

Queued, thanks.

Paolo