linux-kernel - Re: [PATCH] cpufreq: scpi: drop redundant arm_big

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180223042203.GC26947@vireshk-i7>
Date:   Fri, 23 Feb 2018 09:52:03 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] cpufreq: scpi: drop redundant arm_big_little config
 dependency

On 22-02-18, 18:00, Sudeep Holla wrote:

Not sure if 'redundant' is the right term to be used here. I would
rather say: "Fix incorrect config dependency" :)

> Commit 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency)
> removed the SCPI cpufreq dependency on arm_big_little cpufreq driver.
> However the Kconfig entry still depends on ARM_BIG_LITTLE_CPUFREQ
> which is clearly wrong.
> 
> This patch removes that unnecessary Kconfig dependency.
> 
> Fixes: 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency)
> Reported-by: Quentin Perret <quentin.perret@....com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>  drivers/cpufreq/Kconfig.arm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 2e49673a9e21..9bbb5b39d18a 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -44,10 +44,10 @@ config ARM_DT_BL_CPUFREQ
>  
>  config ARM_SCPI_CPUFREQ
>  	tristate "SCPI based CPUfreq driver"
> -	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> +	depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
>  	help
> -	  This adds the CPUfreq driver support for ARM big.LITTLE platforms
> -	  using SCPI protocol for CPU power management.
> +	  This adds the CPUfreq driver support for ARM platforms using SCPI
> +	  protocol for CPU power management.
>  
>  	  This driver uses SCPI Message Protocol driver to interact with the
>  	  firmware providing the CPU DVFS functionality.

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh