linux-kernel - Re: [PATCH v9 4/7] PCI/DPC: Unify and plumb error handling into DPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e3c1878229d1524a918b85d94b5bf82@codeaurora.org>
Date:   Fri, 23 Feb 2018 10:50:50 +0530
From:   poza@...eaurora.org
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dongdong Liu <liudongdong3@...wei.com>,
        Keith Busch <keith.busch@...el.com>, Wei Zhang <wzhang@...com>,
        Sinan Kaya <okaya@...eaurora.org>,
        Timur Tabi <timur@...eaurora.org>
Subject: Re: [PATCH v9 4/7] PCI/DPC: Unify and plumb error handling into DPC

On 2018-02-23 00:53, Randy Dunlap wrote:
> On 02/21/2018 11:46 PM, Oza Pawandeep wrote:
>> Current DPC driver does not do recovery, e.g. calling end-point's 
>> driver's
>> callbacks, which sanitize the sw.
>> 
>> DPC driver implements link_reset callback, and calls pci_do_recovery.
> 
> Hi,
> What does DPC mean?
> 

DPC (Downstream port containment) is PCIe RP or Switch feature, which if 
detects FATAL error messages
halts the outgoing traffic, and PCIe link reset and quiescence 
activities are taken care by HW, and recovery is made.
followed by that; normal operation can be resumed.

>> Signed-off-by: Oza Pawandeep <poza@...eaurora.org>
>> 
> 
>> diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c
>> index 38e40c6..208b427 100644
>> --- a/drivers/pci/pcie/pcie-dpc.c
>> +++ b/drivers/pci/pcie/pcie-dpc.c
> 
>> @@ -82,12 +137,25 @@ static void dpc_wait_link_inactive(struct dpc_dev 
>> *dpc)
>>  		dev_warn(dev, "Link state not disabled for DPC event\n");
>>  }
>> 
>> +/**
>> + * dpc_reset_link - reset link DPC  routine
>  + * @dev: pointer to Root Port's pci_dev data structure
> 
>    * @pdev: ...
> 
>> + *
>> + * Invoked by Port Bus driver when performing link reset at Root 
>> Port.
>> + */
>> +static pci_ers_result_t dpc_reset_link(struct pci_dev *pdev)
>>  {
> 
> You can use 'make W=1 ...' to find kernel-doc warnings like this.
> 

sure thanks for this tip.

ps: I am going to post v11 to address some comments.
> thanks,