linux-kernel - Re: [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180224131137.1b2a79f3@archlinux>
Date:   Sat, 24 Feb 2018 13:11:37 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@...com>
Cc:     Fabrice Gasnier <fabrice.gasnier@...com>, <robh+dt@...nel.org>,
        <linux@...linux.org.uk>, <mark.rutland@....com>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...com>,
        <lars@...afoo.de>, <knaack.h@....de>, <pmeerw@...erw.net>,
        <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <benjamin.gaignard@...aro.org>
Subject: Re: [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add
 missing pinctrl

On Fri, 23 Feb 2018 14:47:36 +0100
Arnaud Pouliquen <arnaud.pouliquen@...com> wrote:

> Hello,
> 
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@...com>

I'm feeling conservative today so will be wanting a devicetree
maintainer ack for this one..

Jonathan

> 
> Regards,
> Arnaud
> 
> On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> >   may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> > 
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> > 
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > index 911492da..ed7520d 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > @@ -32,6 +32,10 @@ Optional properties:
> >  		  to "clock" property. Frequency must be a multiple of the rcc
> >  		  clock frequency. If not, SPI CLKOUT frequency will not be
> >  		  accurate.
> > +- pinctrl-names:	Set to "default".
> > +- pinctrl-0:		List of phandles pointing to pin configuration
> > +			nodes to set pins in mode of operation for dfsdm
> > +			on external pin.
> >  
> >  Contents of a STM32 DFSDM child nodes:
> >  --------------------------------------
> > @@ -68,8 +72,8 @@ Optional properties:
> >  - st,adc-channel-types:	Single-ended channel input type.
> >  			- "SPI_R": SPI with data on rising edge (default)
> >  			- "SPI_F": SPI with data on falling edge
> > -			- "MANCH_R": manchester codec, rising edge = logic 0
> > -			- "MANCH_F": manchester codec, falling edge = logic 1
> > +			- "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> > +			- "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
> >  - st,adc-channel-clk-src: Conversion clock source.
> >  			  - "CLKIN": external SPI clock (CLKIN x)
> >  			  - "CLKOUT": internal SPI clock (CLKOUT) (default)
> >