linux-kernel - Re: [PATCH] tools/memory-model: update: remove rb-dep, smp_read_barrier_depends, and lockless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180224143658.GA3556@andrea>
Date:   Sat, 24 Feb 2018 15:36:58 +0100
From:   Andrea Parri <parri.andrea@...il.com>
To:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:     Akira Yokosawa <akiyks@...il.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Kernel development list <linux-kernel@...r.kernel.org>,
        mingo@...nel.org, Will Deacon <will.deacon@....com>,
        peterz@...radead.org, boqun.feng@...il.com, npiggin@...il.com,
        dhowells@...hat.com, Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        Patrick Bellasi <patrick.bellasi@....com>
Subject: Re: [PATCH] tools/memory-model: update: remove rb-dep,
 smp_read_barrier_depends, and lockless_dereference

On Fri, Feb 23, 2018 at 07:30:13PM -0800, Paul E. McKenney wrote:
> On Sat, Feb 24, 2018 at 12:22:24PM +0900, Akira Yokosawa wrote:
> > On 2018/02/22 07:29:02 +0900, Akira Yokosawa wrote:
> > > On 2018/02/22 2:15, Alan Stern wrote:

[...]

> > >>
> > >> Akira pointed out some typos in the original patch, and he noted that
> > >> cheatsheet.txt should be updated to indicate how unsuccessful RMW
> > >> operations relate to address dependencies.
> > > 
> > > My point was to separate unannotated loads from READ_ONCE(), if the
> > > cheatsheet should concern such accesses as well.
> > > Unsuccessful RMW operations were brought up by Andrea.
> > >
> > 
> > Paul, can you amend above paragraph in the change log to something like:
> > 
> >     Akira pointed out some typos in the original patch, and he noted that
> >     cheatsheet.txt should be updated to indicate READ_ONCE() implies
> >     address dependency, which invited Andrea's observation that it should
> >     also be updated to indicate how unsuccessful RMW operations relate to
> >     address dependencies.
> > 
> > , if Alan and Andrea are OK with the amendment.
> > 
> > Also, please append my Acked-by.
> > 
> > Acked-by: Akira Yokosawa <akiyks@...il.com>
> 
> I can still amend this, and have added your Acked-by.  If Alan and Andrea
> OK with your change, I will apply that also.

LGTM. Thanks,

  Andrea


>