linux-kernel - Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r2pah1c2.fsf@linkitivity.dja.id.au>
Date:   Sun, 25 Feb 2018 02:08:45 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Paul Burton <paul.burton@...s.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> writes:

> Hi Daniel,
>
> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens <dja@...ens.net> wrote:
>> This matches the header at the top of the file and squashes:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
>> see include/linux/module.h for more information
>>
>> Signed-off-by: Daniel Axtens <dja@...ens.net>
>> ---
>>  drivers/auxdisplay/img-ascii-lcd.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
>> index db040b378224..7315ffa79537 100644
>> --- a/drivers/auxdisplay/img-ascii-lcd.c
>> +++ b/drivers/auxdisplay/img-ascii-lcd.c
>> @@ -441,3 +441,5 @@ static struct platform_driver img_ascii_lcd_driver = {
>>         .remove = img_ascii_lcd_remove,
>>  };
>>  module_platform_driver(img_ascii_lcd_driver);
>> +
>> +MODULE_LICENSE("GPL");
>
> This was submitted just a few days before yours, and now it is in at
> 09c479f7f1fbfaf848e5813996793966cd50be81
> ("auxdisplay: img-ascii-lcd: add missing
> MODULE_DESCRIPTION/AUTHOR/LICENSE").
>
> In any case, thanks for the patch! :-)

Thanks!

I was submitting the patches in part because I was considering
submitting a change that made the license warning a fatal error and I
wanted to make sure I had covered the obvious missing ones first.

Would making the warning fatal impact on you?

Regards,
Daniel
>
> Cheers,
> Miguel
>
>> --
>> 2.11.0
>>