lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Feb 2018 09:57:51 +0800 From: Baolin Wang <baolin.wang@...aro.org> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, devicetree <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Mark Brown <broonie@...nel.org> Subject: Re: [PATCH v4 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform Hi Andy, On 23 February 2018 at 21:35, Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Fri, Feb 23, 2018 at 6:44 AM, Baolin Wang <baolin.wang@...aro.org> wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set input/output and has >> the interrupt capability. >> > > Sorry, couple comments below. > >> Signed-off-by: Baolin Wang <baolin.wang@...aro.org> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> > >> +/* We have 16 banks GPIOs and each bank contain 16 GPIOs */ >> +#define SPRD_GPIO_BANK_NR 16 >> +#define SPRD_GPIO_NR 256 > >> +#define SPRD_GPIO_BANK_SIZE 0x80 > > 128 ? Um, I still would like to use 0x80 here to keep consistent with our GPIO Spec. > >> + irq->handler = handle_simple_irq; > > Shouldn't be handle_bad_irq() ? Yes, handle_bad_irq() is better. >> +static const struct of_device_id sprd_gpio_of_match[] = { >> + { .compatible = "sprd,sc9860-gpio", }, > >> + { /* end of list */ }, > > Comma is redundant. Absence of it even better at compile time if at > some weird case the item goes after a terminator. Sure. Thanks. -- Baolin.wang Best Regards
Powered by blists - more mailing lists