linux-kernel - Re: [V9fs-developer] [PATCH] fs/9p: don't set SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A90D23F.5070601@huawei.com>
Date:   Sat, 24 Feb 2018 10:47:27 +0800
From:   jiangyiwen <jiangyiwen@...wei.com>
To:     <v9fs-developer@...ts.sourceforge.net>, <viro@...iv.linux.org.uk>
CC:     <ericvh@...il.com>, <rminnich@...dia.gov>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Latchesar Ionkov" <lucho@...kov.net>, Greg Kurz <groug@...d.org>
Subject: Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default

On 2018/2/9 14:13, jiangyiwen wrote:
> User use some syscall, for example mmap(v9fs_file_mmap), it will not
> update atime even if user's mnt_flags have MNT_NOATIME, because
> v9fs default set SB_NOATIME in v9fs_set_super.
> 
> For supporting access time is updated when user mount with relatime,
> we should clear SB_NOATIME by default.
> 
> Signed-off-by: Yiwen Jiang <jiangyiwen@...wei.com>
> ---
>  fs/9p/vfs_super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
> index af03c2a..48ce504 100644
> --- a/fs/9p/vfs_super.c
> +++ b/fs/9p/vfs_super.c
> @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
>  	if (v9ses->cache)
>  		sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
> 
> -	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
> +	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
>  	if (!v9ses->cache)
>  		sb->s_flags |= SB_SYNCHRONOUS;
> 
Hi Alexander Viro and Eric,

My patch has already sent two weeks, but nobody help me
to review, I have a question about now who is the v9fs's
maintainer? Or who can help me review the patch?

I hope v9fs's maintainer can give me some advices or
merge into the mainline if it has no problem.

Thanks,
Yiwen.