| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Feb 2018 07:18:21 -0800
From: Matthew Wilcox <willy@...radead.org>
To: Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc: gregkh@...uxfoundation.org, oneukum@...e.com, corbet@....net,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore
On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote:
> v2: Use in-kernel tolower() function.
... why are you using tolower at all?
You've got 13 quirks already; you may need to use upper case as well
before too long.
> + quirk = vmalloc(sizeof(struct quirk_entry));
vmalloc? For a struct that's 24 bytes? You know that allocates an
entire 4k page, right?
Powered by blists - more mailing lists