linux-kernel - Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 08:51:45 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, <ebiederm@...ssion.com>,
        Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones

Hi Andy,

At 02/23/2018 08:40 PM, Andy Shevchenko wrote:
> On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang <douly.fnst@...fujitsu.com> wrote:
>> The pending interrupt check code is old, update the following code.
>>
>>    -Replace for() with for_each_set_bit()
> 
>> -                       for (j = 31; j >= 0; j--) {
>> -                               if (value & (1<<j)) {
>> +                       for_each_set_bit(j, &value, 32) {
> 
> for_each_set_bit(), mind 'set' part, is equivalent to for-if pair...
> 
>> +                               if (j) {
> 
> ...here you just exclude bit 0 from consideration by unknown reason.
> 

Oops! my fault, will modify it.

Thanks,
	dou

>>                                          ack_APIC_irq();
>>                                          acked++;
>>                                  }
>>                          }
>