linux-kernel - Re: [PATCH v2 2/2] i2c: piix4: Use request_muxed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180226214307.irourq2svpd7ok7e@ninjato>
Date:   Mon, 26 Feb 2018 22:43:07 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: piix4: Use request_muxed_region


> It is an alternate and somewhat simpler solution which does not
> attempt to change the kernel API. My primary goal was to find
> a solution for the immediate problem between the watchdog and
> i2c drivers. My solution does not attempt to fix the access problem
> for (initialization) functions with no return code. At the same time,
> I prefer to use functions which _do_ return an error if that is possible
> since it _may_ after all be that there are other users calling
> request_region().
> 
> Having said that, I'll be just as happy if Zoltan's series is accepted
> instead of this patch (except for patch #5; the watchdog driver has
> already been converted to use request_muxed_region).

Thanks for the explanation!

So, as I understand: I can apply this patch to fix the immediate (and
long standing) problem and decouple it from the API change. The latter
can then still be worked on and the changes for the piix driver should
then be minimal. Correct?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)