linux-kernel - Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180226075625.kcksm35y4clqvi5l@mwanda>
Date:   Mon, 26 Feb 2018 10:56:25 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ivan Safonov <insafonov@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, Hans de Goede <hdegoede@...hat.com>,
        Janani Sankara Babu <jananis37@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote:
> Custom AES decrypt implementation replaced with lib80211 library.
> 
> Signed-off-by: Ivan Safonov <insafonov@...il.com>

The new code looks like original RTL code (really bad) so I'm guessing
you copy and pasted the code from somewhere else?

The idea is good, but RTL code is painful to look at.

regards,
dan carpenter