linux-kernel - Re: [PATCH v2 12/12] extcon: axp288: Set USB role where necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <478db279-c9c6-7fd2-b275-88789631cbda@redhat.com>
Date:   Mon, 26 Feb 2018 09:07:42 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 12/12] extcon: axp288: Set USB role where necessary

Hi,

On 25-02-18 19:51, Randy Dunlap wrote:
> Hi,
> 
> On 02/25/2018 07:25 AM, Hans de Goede wrote:
>   
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index a7bca4207f44..de15bf55895b 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -30,7 +30,8 @@ config EXTCON_ARIZONA
>>   
>>   config EXTCON_AXP288
>>   	tristate "X-Power AXP288 EXTCON support"
>> -	depends on MFD_AXP20X && USB_PHY
>> +	depends on MFD_AXP20X && USB_SUPPORT && X86
> 
> Could that be:
> 	depends on MFD_AXP20X && USB_SUPPORT && (X86 || COMPILE_TEST)
> 
> or is there some reason that it won't even build on other $ARCH?

It uses:

#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>

So it really should only be build on X86, it always was an X86 only
driver, but it now it really depends on X86.

Thank you for all the reviews. I will prepare a v3 with all your
proposed fixes soon(ish).
Regards,

Hans


>> +	select USB_ROLE_SWITCH
>>   	help
>>   	  Say Y here to enable support for USB peripheral detection
>>   	  and USB MUX switching by X-Power AXP288 PMIC.
> 
> thanks,
>