linux-kernel - Re: [PATCH] m68k/mac: Fix apparent race condition in Baboon interrupt dispatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdU4+Ag0VEVB0p7HG+J-Pgr95XmSwdB-PF3LO6CiVxe0kA@mail.gmail.com>
Date:   Mon, 26 Feb 2018 10:46:04 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/mac: Fix apparent race condition in Baboon interrupt dispatch

On Sun, Jan 28, 2018 at 12:51 AM, Finn Thain <fthain@...egraphics.com.au> wrote:
> The algorithm used in baboon_irq() appears to be subject to a race
> condition: an IRQ flag could be lost if asserted between the MOV
> instructions from and to the interrupt flag register. However,
> testing shows that the write to the flag register has no effect.
> Rewrite this loop to remove the apparent race condition.
>
> No-one seems to know how to clear Baboon IRQ flags, or whether
> that's even possible, so add a comment about this.
>
> Tested-by: Stan Johnson <userm57@...oo.com>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Thanks, applied and queue for v4.17.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds