linux-kernel - Re: [PATCH] eeprom: New ee1004 driver for DDR4 memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MernxfN-P29HnLUFzAiX-UiFx32ZYZW_v6_BH9dXnfCfw@mail.gmail.com>
Date:   Mon, 26 Feb 2018 14:40:42 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] eeprom: New ee1004 driver for DDR4 memory

2018-02-26 10:20 GMT+01:00 Jean Delvare <jdelvare@...e.de>:
> The EEPROMs which hold the SPD data on DDR4 memory modules are no
> longer standard AT24C02-compatible EEPROMs. They are 512-byte EEPROMs
> which use only 1 I2C address for data access. You need to switch
> between the lower page and the upper page of data by sending commands
> on the SMBus.
>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> ---
>  drivers/misc/eeprom/Kconfig  |   11 +
>  drivers/misc/eeprom/Makefile |    1
>  drivers/misc/eeprom/ee1004.c |  281 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 293 insertions(+)
>

Hi Jean,

is there any reason not to use regmap as is done currently in at24? It
would spare you a lot of code.

Best regards,
Bartosz Golaszewski