linux-kernel - RE: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure GUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR12MB1916D6F66B70E73013D1DA60F8C10@DM5PR12MB1916.namprd12.prod.outlook.com>
Date:   Mon, 26 Feb 2018 16:01:35 +0000
From:   "Ghannam, Yazen" <Yazen.Ghannam@....com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...e.de>,
        the arch/x86 maintainers <x86@...nel.org>
Subject: RE: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure
 GUIDs

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@...aro.org]
> Sent: Saturday, February 24, 2018 11:41 AM
> To: Ghannam, Yazen <Yazen.Ghannam@....com>
> Cc: linux-efi@...r.kernel.org; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>; Borislav Petkov <bp@...e.de>; the arch/x86
> maintainers <x86@...nel.org>
> Subject: Re: [PATCH 4/8] efi: Decode UEFI-defined IA32/X64 Error Structure
> GUIDs
> 
> On 23 February 2018 at 20:03, Yazen Ghannam
> <Yazen.Ghannam@....com> wrote:
> > From: Yazen Ghannam <yazen.ghannam@....com>
> >
> > For easier handling, match the known IA32/X64 error structure GUIDs to
> > enums.
> >
> > Also, print out the name of the matching Error Structure Type.
> >
> > GUIDs taken from UEFI 2.7 section N.2.4.2.1 IA32/X64 Processor Error
> > Information Structure.
> >
> > Cc: <stable@...r.kernel.org> # 4.16.x
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> > ---
> >  drivers/firmware/efi/cper-x86.c | 41
> +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >
> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-
> x86.c
> > index 9d608f742c98..3b86223bdb67 100644
> > --- a/drivers/firmware/efi/cper-x86.c
> > +++ b/drivers/firmware/efi/cper-x86.c
> > @@ -14,17 +14,53 @@
...
> >  void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia
> *proc)
> >  {
> >         int i;
> >         struct cper_ia_err_info *err_info;
> >         char newpfx[64];
> > +       enum err_types err_type;
> >
> 
> Can you make this an u8 please? The signedness of an enum is not well
> defined, and you only check the upper bound below.
> 

Yes, will do.

Thanks,
Yazen