linux-kernel - [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1519666595-41362-2-git-send-email-aams@amazon.com>
Date:   Mon, 26 Feb 2018 17:36:34 +0000
From:   Amit Shah <aams@...zon.com>
To:     <xen-devel@...ts.xenproject.org>
CC:     <linux-kernel@...r.kernel.org>, Amit Shah <aams@...zon.com>,
        <stable@...r.kernel.org>,
        Roger Pau Monné <roger.pau@...rix.com>,
        David Vrabel <david.vrabel@...rix.com>,
        "Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
        Eduardo Valentin <eduval@...zon.com>,
        Juergen Gross <jgross@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Liu Shuo <shuo.a.liu@...el.com>,
        Anoob Soman <anoob.soman@...rix.com>
Subject: [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups

When an MSI descriptor was not available, the error path would try to
unbind an irq that was never acquired - potentially unbinding an
unrelated irq.

Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups")
Reported-by: Hooman Mirhadi <mirhadih@...zon.com>
CC: <stable@...r.kernel.org>
CC: Roger Pau Monné <roger.pau@...rix.com>
CC: David Vrabel <david.vrabel@...rix.com>
CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>
CC: Eduardo Valentin <eduval@...zon.com>
CC: Juergen Gross <jgross@...e.com>
CC: Thomas Gleixner <tglx@...utronix.de>
CC: "K. Y. Srinivasan" <kys@...rosoft.com>
CC: Liu Shuo <shuo.a.liu@...el.com>
CC: Anoob Soman <anoob.soman@...rix.com>
Signed-off-by: Amit Shah <aams@...zon.com>
---
 drivers/xen/events/events_base.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 1ab4bd1..b6b8b29 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -749,6 +749,7 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
 	}
 
 	ret = irq_set_msi_desc(irq, msidesc);
+	i--;
 	if (ret < 0)
 		goto error_irq;
 out:
-- 
2.7.3.AMZN

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B