linux-kernel - Re: [PATCH V4 net 1/3] Revert "tuntap: add missing xdp flush"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180226.135004.744356947488629833.davem@davemloft.net>
Date:   Mon, 26 Feb 2018 13:50:04 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jasowang@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mst@...hat.com, sergei.shtylyov@...entembedded.com,
        christoffer.dall@...aro.org, brouer@...hat.com
Subject: Re: [PATCH V4 net 1/3] Revert "tuntap: add missing xdp flush"

From: Jason Wang <jasowang@...hat.com>
Date: Sat, 24 Feb 2018 11:32:24 +0800

> This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The
> reason is we try to batch packets for devmap which causes calling
> xdp_do_flush() in the process context. Simply disabling preemption
> may not work since process may move among processors which lead
> xdp_do_flush() to miss some flushes on some processors.
> 
> So simply revert the patch, a follow-up patch will add the xdp flush
> correctly.
> 
> Reported-by: Christoffer Dall <christoffer.dall@...aro.org>
> Fixes: 762c330d670e ("tuntap: add missing xdp flush")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied.