linux-kernel - Re: [PATCH V4 net 3/3] tuntap: correctly add the missing XDP flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 13:50:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jasowang@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mst@...hat.com, sergei.shtylyov@...entembedded.com,
        christoffer.dall@...aro.org, brouer@...hat.com
Subject: Re: [PATCH V4 net 3/3] tuntap: correctly add the missing XDP flush

From: Jason Wang <jasowang@...hat.com>
Date: Sat, 24 Feb 2018 11:32:26 +0800

> We don't flush batched XDP packets through xdp_do_flush_map(), this
> will cause packets stall at TX queue. Consider we don't do XDP on NAPI
> poll(), the only possible fix is to call xdp_do_flush_map()
> immediately after xdp_do_redirect().
> 
> Note, this in fact won't try to batch packets through devmap, we could
> address in the future.
> 
> Reported-by: Christoffer Dall <christoffer.dall@...aro.org>
> Fixes: 761876c857cb ("tap: XDP support")
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied, and all 3 patches queued up for -stable.

Thanks.