linux-kernel - Re: [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db4a0e0b-31cf-9c37-ba89-c0e7b6c99d87@oracle.com>
Date:   Mon, 26 Feb 2018 15:02:33 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Amit Shah <aams@...zon.com>, xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Roger Pau Monné <roger.pau@...rix.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Eduardo Valentin <eduval@...zon.com>,
        Juergen Gross <jgross@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Liu Shuo <shuo.a.liu@...el.com>,
        Anoob Soman <anoob.soman@...rix.com>
Subject: Re: [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message
 groups

On 02/26/2018 12:36 PM, Amit Shah wrote:
> When an MSI descriptor was not available, the error path would try to
> unbind an irq that was never acquired - potentially unbinding an
> unrelated irq.
>
> Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups")
> Reported-by: Hooman Mirhadi <mirhadih@...zon.com>
> CC: <stable@...r.kernel.org>
> CC: Roger Pau Monné <roger.pau@...rix.com>
> CC: David Vrabel <david.vrabel@...rix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> CC: Eduardo Valentin <eduval@...zon.com>
> CC: Juergen Gross <jgross@...e.com>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: "K. Y. Srinivasan" <kys@...rosoft.com>
> CC: Liu Shuo <shuo.a.liu@...el.com>
> CC: Anoob Soman <anoob.soman@...rix.com>
> Signed-off-by: Amit Shah <aams@...zon.com>
> ---
>  drivers/xen/events/events_base.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index 1ab4bd1..b6b8b29 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -749,6 +749,7 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
>  	}
>  
>  	ret = irq_set_msi_desc(irq, msidesc);
> +	i--;
>  	if (ret < 0)
>  		goto error_irq;

We really only need to do this in case of an error.

(And this patch needs to go to stable trees as well.)

Thanks
-boris