linux-kernel - Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227064732.GB171936@decatoncale.mtv.corp.google.com>
Date:   Mon, 26 Feb 2018 22:47:32 -0800
From:   Benson Leung <bleung@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        lee.jones@...aro.org
Cc:     lee.jones@...aro.org, groeck@...omium.org,
        andy.shevchenko@...il.com, kernel@...labora.com,
        gwendal@...omium.org, linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Olof Johansson <olof@...om.net>, bleung@...gle.com
Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

Hi Enric,

Thanks for sending this.

On Mon, Feb 26, 2018 at 11:26:01AM +0100, Enric Balletbo i Serra wrote:
> From: Douglas Anderson <dianders@...omium.org>
> 
> We should stop our worker thread while we're suspended.  If we don't
> then we'll get messages like:
> 
>   cros-ec-spi spi5.0: spi transfer failed: -108
>   cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108
>   cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
> 
> Changes in v3:
> - [3/8] Add Reviewed-by Andy Shevchenko.
> 
> Changes in v2:
> - [3/8] That patch is new in this series.
> 
>  drivers/mfd/cros_ec_dev.c                 |  4 ++++
>  drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++
>  include/linux/mfd/cros_ec.h               |  2 ++

Looks like this will need an immutable branch between mfd and chrome-platform
again, Lee.

Do you want to do one, or should I?

Thanks,
Benson


-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)