linux-kernel - Re: 91f606a8fa ("x86/mm: Replace compile-time checks for 5-level .."): BUG: kernel reboot-without-warning in boot stage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180227082142.7qxtlcx3hkb22abn@node.shutemov.name>
Date:   Tue, 27 Feb 2018 11:21:42 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     kernel test robot <fengguang.wu@...el.com>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        LKP <lkp@...org>, linux-pm@...r.kernel.org,
        linux-efi@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        wfg@...ux.intel.com
Subject: Re: 91f606a8fa ("x86/mm: Replace compile-time checks for 5-level
 .."): BUG: kernel reboot-without-warning in boot stage

On Mon, Feb 26, 2018 at 11:14:06PM +0800, kernel test robot wrote:
> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm
> 
> commit 91f606a8fa68264224cbc76888fa8649cdbe9990
> Author:     Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> AuthorDate: Wed Feb 14 21:25:41 2018 +0300
> Commit:     Ingo Molnar <mingo@...nel.org>
> CommitDate: Fri Feb 16 10:48:49 2018 +0100
> 
>     x86/mm: Replace compile-time checks for 5-level paging with runtime-time checks
>     
>     This patch converts the of CONFIG_X86_5LEVEL check to runtime checks for
>     p4d folding.
>     
>     Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
>     Cc: Andy Lutomirski <luto@...nel.org>
>     Cc: Arjan van de Ven <arjan@...ux.intel.com>
>     Cc: Borislav Petkov <bp@...e.de>
>     Cc: Dan Williams <dan.j.williams@...el.com>
>     Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>     Cc: David Woodhouse <dwmw2@...radead.org>
>     Cc: Josh Poimboeuf <jpoimboe@...hat.com>
>     Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Cc: Thomas Gleixner <tglx@...utronix.de>
>     Cc: linux-mm@...ck.org
>     Link: http://lkml.kernel.org/r/20180214182542.69302-9-kirill.shutemov@linux.intel.com
>     Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> 98219dda2a  x86/mm: Fold p4d page table layer at runtime
> 91f606a8fa  x86/mm: Replace compile-time checks for 5-level paging with runtime-time checks
> 1ea4fe8497  Merge branch 'x86/boot' into x86/mm, to unify branches
> 94991480c2  Merge branch 'x86/pti'
> f1753f6424  Add linux-next specific files for 20180226

Patch below should help. Please check.

diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
index 81dda8d1d0bd..163e01a0631d 100644
--- a/arch/x86/include/asm/pgtable_64.h
+++ b/arch/x86/include/asm/pgtable_64.h
@@ -224,9 +224,9 @@ static inline void native_set_p4d(p4d_t *p4dp, p4d_t p4d)
 		return;
 	}
 
-	pgd = native_make_pgd(p4d_val(p4d));
+	pgd = native_make_pgd(native_p4d_val(p4d));
 	pgd = pti_set_user_pgd((pgd_t *)p4dp, pgd);
-	*p4dp = native_make_p4d(pgd_val(pgd));
+	*p4dp = native_make_p4d(native_pgd_val(pgd));
 }
 
 static inline void native_p4d_clear(p4d_t *p4d)
-- 
 Kirill A. Shutemov