linux-kernel - Re: [PATCH] xen: use hvc console for dom0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bee63f6-6681-5cb1-b763-66cf8304ae84@suse.com>
Date:   Tue, 27 Feb 2018 10:26:40 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org
Cc:     jbeulich@...e.com
Subject: Re: [PATCH] xen: use hvc console for dom0

On 26/02/18 20:02, Boris Ostrovsky wrote:
> On 02/26/2018 06:08 AM, Juergen Gross wrote:
>> Today the hvc console is added as a preferred console for pv domUs
>> only. As this requires a boot parameter for getting dom0 messages per
>> default add it for dom0, too.
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
>> ---
>>  arch/x86/xen/enlighten_pv.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
>> index c047f42552e1..d27740a80c5e 100644
>> --- a/arch/x86/xen/enlighten_pv.c
>> +++ b/arch/x86/xen/enlighten_pv.c
>> @@ -1377,7 +1377,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
>>  	if (!xen_initial_domain()) {
>>  		add_preferred_console("xenboot", 0, NULL);
>>  		add_preferred_console("tty", 0, NULL);
>> -		add_preferred_console("hvc", 0, NULL);
>>  		if (pci_xen)
>>  			x86_init.pci.arch_init = pci_xen_init;
>>  	} else {
>> @@ -1410,6 +1409,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
>>  
>>  		xen_boot_params_init_edd();
>>  	}
>> +
>> +	add_preferred_console("hvc", 0, NULL);
>> +
> 
> Won't this prevent dom0 output from showing up on vga console by default?

Right, we need to add "tty", too.

Will send V2.


Juergen