linux-kernel - Re: [PATCH v2] printk: move dump stack related code to lib/dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180227100351.k7ijt7zvpf5hzk66@pathway.suse.cz>
Date:   Tue, 27 Feb 2018 11:03:51 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Dave Young <dyoung@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v2] printk: move dump stack related code to
 lib/dump_stack.c

On Tue 2018-02-13 17:35:05, Sergey Senozhatsky wrote:
> On (02/13/18 15:28), Dave Young wrote:
> > 
> > dump_stack related stuff should belong to lib/dump_stack.c thus move them
> > there. Also conditionally compile lib/dump_stack.c since dump_stack code
> > does not make sense if printk is disabled.
> > 
> > Signed-off-by: Dave Young <dyoung@...hat.com>
> > Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

Looks OK to me as well.

Reviewed-by: Petr Mladek <pmladek@...e.com>

I have pushed it into printk.git, branch for-4.17.


> The patch also saves us some additional memory on !PRINTK configs.
> For example things like this
> 
> 	if (kobj->state_initialized) {
> 		/* do not error out as sometimes we can recover */
> 		printk(KERN_ERR "kobject (%p): tried to init an initialized "
> 		       "object, something is seriously wrong.\n", kobj);
> 		dump_stack();
> 	}
> 
> now we won't have that dump_stack() call, which does not seems to be doing
> anything useful anyway when printk() is not available.

Yup.

Best Regards,
Petr