linux-kernel - Re: [PATCH v3 6/8] MIPS: mscc: add ocelot PCB123 device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227155747.GQ29460@jhogan-linux.mipstec.com>
Date:   Tue, 27 Feb 2018 15:57:48 +0000
From:   James Hogan <james.hogan@...s.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:     Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 6/8] MIPS: mscc: add ocelot PCB123 device tree

On Tue, Feb 27, 2018 at 04:54:44PM +0100, Alexandre Belloni wrote:
> On 14/02/2018 at 17:00:42 +0000, James Hogan wrote:
> > On Tue, Jan 16, 2018 at 11:12:38AM +0100, Alexandre Belloni wrote:
> > > Add a device tree for the Microsemi Ocelot PCB123 evaluation board.
> > > 
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > 
> > Please Cc DT folk.
> > 
> 
> I can do but again, I don't think they care.
> 
> > > diff --git a/arch/mips/boot/dts/mscc/ocelot_pcb123.dts b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts
> > > new file mode 100644
> > > index 000000000000..42bd404471f6
> > > --- /dev/null
> > > +++ b/arch/mips/boot/dts/mscc/ocelot_pcb123.dts
> > > @@ -0,0 +1,27 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> > > +/* Copyright (c) 2017 Microsemi Corporation */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "ocelot.dtsi"
> > > +
> > > +/ {
> > > +	compatible = "mscc,ocelot-pcb123", "mscc,ocelot";
> > 
> > Should mscc,ocelot-pcb123 be added to the mscc DT binding documentation
> > in the other patch?
> > 
> 
> On ARM at least, we don't document the board compatibles because this
> will be a huge list without much benefit as they are mostly unused.
> Still, it is nice to have in case something specific needs to be done
> for a particular board (and hopefully this never happens).
> 
> also, I don't think any other MIPS boards are documented bu if you
> insist, I can either add it in
> Documentation/devicetree/bindings/mips/mscc.txt or create a new file to
> list all the mips board compatibles.

I don't insist. It was a genuine question :-)

Thanks
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)