linux-kernel - Re: [PATCH v2 2/2] xen: events: free irqs in error condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227170740.jcaxsvpepsn6eot2@MacBook-Pro-de-Roger.local>
Date:   Tue, 27 Feb 2018 17:07:40 +0000
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Amit Shah <aams@...zon.com>
CC:     <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Eduardo Valentin <eduval@...zon.com>,
        Juergen Gross <jgross@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Liu Shuo <shuo.a.liu@...el.com>,
        Anoob Soman <anoob.soman@...rix.com>
Subject: Re: [PATCH v2 2/2] xen: events: free irqs in error condition

On Tue, Feb 27, 2018 at 03:55:58PM +0000, Amit Shah wrote:
> In case of errors in irq setup for MSI, free up the allocated irqs.
> 
> Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups")
> Reported-by: Hooman Mirhadi <mirhadih@...zon.com>
> CC: <stable@...r.kernel.org>
> CC: Roger Pau Monné <roger.pau@...rix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> CC: Eduardo Valentin <eduval@...zon.com>
> CC: Juergen Gross <jgross@...e.com>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: "K. Y. Srinivasan" <kys@...rosoft.com>
> CC: Liu Shuo <shuo.a.liu@...el.com>
> CC: Anoob Soman <anoob.soman@...rix.com>
> Signed-off-by: Amit Shah <aams@...zon.com>
> ---
>  drivers/xen/events/events_base.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index c86d10e..a299586 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -750,11 +750,14 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
>  
>  	ret = irq_set_msi_desc(irq, msidesc);
>  	if (ret < 0)
> -		goto error_irq;
> +		goto error_desc;
>  out:
>  	mutex_unlock(&irq_mapping_update_lock);
>  	return irq;
>  error_irq:
> +	while (--nvec >= i)
> +		xen_free_irq(irq + nvec);
> +error_desc:
>  	while (i > 0) {
>  		i--;
>  		__unbind_from_irq(irq + i);

It seems pointless to introduce another label and another loop to fix
something that can be fixed with a single label and a single loop,
this just makes the code more complex for no reason.

IMHO the way to solve this issue is:

while (nvec--) {
	if (nvec >= i)
		xen_free_irq(irq + nvec);
	else
		__unbind_from_irq(irq + nvec);
}

Roger.